-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Allow cross-compiling the Cranelift dist component #145320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rustbot has assigned @albertlarsan68. Use |
r? @jieyouxu |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes make sense to me (as a bootstrap rookie), but more importantly using this patch locally appears to allow me to cross-compile the dist artifacts.
It is surprising that rustfmt didn't complain about missing commas on the new fields though. |
I think it's because it's in a macro. |
Preemptively beta-nominating this as #145252 is also for beta. |
@bors r=shepmaster rollup |
Rollup of 11 pull requests Successful merges: - #143467 (Add ASCII-related methods from `u8` and `MIN`/`MAX` to `core::ascii::Char`) - #144519 (Constify `SystemTime` methods) - #144642 (editorconfig: don't trim trailing whitespace in tests) - #144870 (Stabilize `path_file_prefix` feature) - #145269 (Deprecate RUST_TEST_* env variables) - #145274 (Remove unused `#[must_use]`) - #145289 (chore(ci): upgrade checkout to v5) - #145303 (Docs: Link to payload_as_str() from payload().) - #145308 (Adjust documentation of `dangling`) - #145320 (Allow cross-compiling the Cranelift dist component) - #145325 (Add `cast_init` and `cast_uninit` methods for pointers) r? `@ghost` `@rustbot` modify labels: rollup
cg_clif shouldn't be built for beta at all. |
Rollup merge of #145320 - Kobzol:fix-cranelift-codegen-dist, r=shepmaster Allow cross-compiling the Cranelift dist component Should help unblock #145252 (https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/macos-13.20shutting.20down/with/534032174).
Should help unblock #145252 (https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/macos-13.20shutting.20down/with/534032174).